Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--threads for PUSH and FETCH #537

Closed
yegor256 opened this issue Nov 9, 2018 · 16 comments
Closed

--threads for PUSH and FETCH #537

yegor256 opened this issue Nov 9, 2018 · 16 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@yegor256
Copy link
Collaborator

yegor256 commented Nov 9, 2018

Let's make it possible to configure the amount of threads to use in PUSH and FETCH, when many wallets are provided in the command line. Maybe we can use https://github.com/junegunn/parallelize
@yegor256 yegor256 added bug Something isn't working enhancement New feature or request labels Nov 12, 2018
@0crat 0crat added the scope label Nov 12, 2018
@0crat
Copy link
Collaborator

0crat commented Nov 12, 2018

Job #537 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Nov 12, 2018

Bug was reported, see §29: +15 point(s) just awarded to @yegor256/z

@yegor256
Copy link
Collaborator Author

@0crat assign @emilianodellacasa

@0crat
Copy link
Collaborator

0crat commented Nov 16, 2018

@0crat assign @emilianodellacasa (here)

@yegor256 The job #537 assigned to @emilianodellacasa/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Nov 16, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Nov 21, 2018

@emilianodellacasa/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

emilianodellacasa added a commit to emilianodellacasa/zold that referenced this issue Nov 22, 2018
@emilianodellacasa
Issue zold-io#537 - --threads for PUSH and FETCH
d34e704
@emilianodellacasa emilianodellacasa mentioned this issue Nov 22, 2018
Merged
@emilianodellacasa
Copy link
Contributor

@0crat wait - PR submitted, waiting for review

@0crat
Copy link
Collaborator

0crat commented Nov 23, 2018

@0crat wait - PR submitted, waiting for review (here)

@emilianodellacasa The impediment for #537 was registered successfully by @emilianodellacasa/z

emilianodellacasa added a commit to emilianodellacasa/zold that referenced this issue Nov 26, 2018
@emilianodellacasa
Issue zold-io#537 - Fixing rubocop code smells
19da2d7
emilianodellacasa added a commit to emilianodellacasa/zold that referenced this issue Nov 26, 2018
@emilianodellacasa
Issue zold-io#537 - Test modified for fecthing
534e6e3
emilianodellacasa added a commit to emilianodellacasa/zold that referenced this issue Nov 26, 2018
@emilianodellacasa
Issue zold-io#537 - Test modified for pushing
ceb8fab
@emilianodellacasa
Copy link
Contributor

@yegor256 PR #569 has been merged, please close this issue

emilianodellacasa added a commit to emilianodellacasa/zold that referenced this issue Nov 27, 2018
@emilianodellacasa
Merge remote-tracking branch 'upstream/master' into issue_554
791898f 
* upstream/master:
  zold-io#572 tested and fixed
  Issue zold-io#537 - Test modified for pushing
  Issue zold-io#537 - Test modified for fecthing
  Issue zold-io#537 - Fixing rubocop code smells
  Change link of travis build status to master branch in README
  Issue zold-io#537 - --threads for PUSH and FETCH
  zold-io#568 new location of lock files
  zold-io#568 Remotes thread safety
  zold-io#568 --queue-limit
  zold-io#566 fixed
  zold-io#563 --no-cache
  Isse zold-io#553 - Excluding memory-dump from test
@yegor256
Copy link
Collaborator Author

yegor256 commented Dec 3, 2018

@emilianodellacasa thanks!

@yegor256 yegor256 closed this as completed Dec 3, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

@ypshenychka/z please review this job completed by @emilianodellacasa/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Dec 3, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

The job #537 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

@0crat quality good (here)

@ypshenychka There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@0fcab520-2251-43c3-ae56-6631ec564b80, thread: AsyncProc-5
com.jcabi.xml.ListWrapper[162] com.jcabi.xml.ListWrapper$NodeNotFoundException: XPath 'text()' not found in '<param name="payment_id"/>': Index (0) is out of bounds (size=0)

0.38.5: CID: b7a00e2b-ed59-483a-af13-f84a4b65e329, Type: "Pay cash"

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @emilianodellacasa/z

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emilianodellacasa @yegor256 @ypshenychka @0crat