Merge c646f5d into 6a9c193

zoltantothcom · Apr 2, 2020 · 22f051b · 22f051b
2 parents 6a9c193 + c646f5d
commit 22f051b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -27,6 +27,7 @@ JavaScript disabled? No problem! Nicely degrades to original `<select>`.
 | Option | Required | Description                                                        |
 | ------ | -------- | ------------------------------------------------------------------ |
 | elem   | yes      | _id_ of the select you want to replace **or** a direct DOM element |
+| bubbles   | no      | Boolean indicating whether the change event of the select bubbles |
 
 ## Methods
 

diff --git a/dist/vanilla-js-dropdown.min.js b/dist/vanilla-js-dropdown.min.js
diff --git a/docs/javascript/vanilla-js-dropdown.min.js b/docs/javascript/vanilla-js-dropdown.min.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/javascript/vanilla-js-dropdown.js b/src/javascript/vanilla-js-dropdown.js
@@ -12,8 +12,8 @@
  * @param {(string|Object)} options.elem - HTML id of the select or the DOM element.
  */
 var CustomSelect = function(options) {
-  var elem =
-      typeof options.elem === 'string' ? document.getElementById(options.elem) : options.elem,
+    var elem = typeof options.elem === 'string' ? document.getElementById(options.elem) : options.elem;
+    var bubbles = typeof options.bubbles === 'boolean' ? true : false,
     mainClass = 'js-Dropdown',
     titleClass = 'js-Dropdown-title',
     listClass = 'js-Dropdown-list',
@@ -117,7 +117,7 @@ var CustomSelect = function(options) {
       elem.options.selectedIndex = t.getAttribute('data-index');
 
       //trigger 'change' event
-      var evt = new CustomEvent('change');
+      var evt = bubbles ? new CustomEvent('change', {bubbles: true}) : new CustomEvent('change');
       elem.dispatchEvent(evt);
 
       // highlight the selected