Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-GET requests #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mateusg
Copy link

@mateusg mateusg commented May 20, 2018

This is a solution for #121. I needed this myself while running some perf tests this week, so I took the opportunity to patch the gem, clean up and add tests.

I also had to find a way to set the Content-Type header, because the request I was testing was a JSON request and the gem did not support setting that header through HTTP_ variables (looks like it's a restriction from Rack, actually).

Another thing I had to do was disable the CSRF protection before initializing the app. I did that because non-GET requests require an authenticity token and I couldn't find a way to generate a valid one from the Rails.application context. I'm open to suggestions.

I really appreciate the work you've done with this gem @schneems (and everyone else who has contributed), it has helped me so much to investigate and find the memory leaks. It felt like I had everything I needed in a single tool. 馃檪馃憦

@lessless
Copy link

Hi guys! Any progress on this one? Can be useful for applications that doesn't have GET routes at all

@d4rky-pl
Copy link

Bump

@mateusg mateusg changed the title Add support to non-GET requests Add support for non-GET requests Jul 30, 2021
@pftg
Copy link

pftg commented Dec 6, 2021

Instead of extending running of curl, will it be better to allow to provide a path to some script that will be triggered, and encapsulate there all those curl or non curl commands?

@jodosha
Copy link

jodosha commented Dec 22, 2021

+1

@Judobob
Copy link

Judobob commented Oct 25, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants