Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7 1 support #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rails 7 1 support #71

wants to merge 2 commits into from

Commits on Dec 30, 2023

  1. Add a Rails 7.1 Gemfile. 

    See tests fail with following stack:

LayoutsTest#test_no_layout:
ActionView::Template::Error: undefined method `valid_encoding?' for an instance of ActionView::OutputBuffer
    kramdown (2.4.0) lib/kramdown/parser/base.rb:92:in `adapt_source'
    kramdown (2.4.0) lib/kramdown/parser/kramdown.rb:90:in `parse'
    kramdown-parser-gfm (1.1.0) lib/kramdown/parser/gfm.rb:56:in `parse'
    kramdown (2.4.0) lib/kramdown/parser/base.rb:69:in `parse'
    kramdown (2.4.0) lib/kramdown/document.rb:102:in `initialize'
    /Users/james/Projects/James/maildown/lib/maildown/markdown_engine.rb:53:in `new'
    /Users/james/Projects/James/maildown/lib/maildown/markdown_engine.rb:53:in `block in default_html_block'
    /Users/james/Projects/James/maildown/lib/maildown/markdown_engine.rb:24:in `to_html'
    app/views/user_no_layout_mailer/welcome.md+erb:1
    actionview (7.1.2) lib/action_view/base.rb:264:in `public_send'
    actionview (7.1.2) lib/action_view/base.rb:264:in `_run'
    actionview (7.1.2) lib/action_view/template.rb:261:in `block in render'
    @cowlibob
    cowlibob committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    b520fae View commit details
    Browse the repository at this point in the history

  2. Rails 7.1 appears to pass an ActionView::OutputBuffer, rather than a … 

    …string. Several String methods are used, but unsupported on the ActionView::OutputBuffer (for example `valid_encoding?` and `encode`).
    @cowlibob
    cowlibob committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    2347d47 View commit details
    Browse the repository at this point in the history