Return 422 - :unprocessable_entity when form submissions fails (#294)

* Adding HTTP Status Code for failed #update action
Co-authored-by: Romanos Fessas <romanos@fessas.com>

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## Unreleased
 
+* Return `422` (`:unprocessable_entity`) when form submissions fails. Turbo requires an HTTP Status code between 400-499 or 500-599 when a FormSubmission request fails. This pull request makes wicked compatible with Turbo Drive (https://github.com/zombocom/wicked/pull/294)
 * Pass the provided step when raising InvalidStepError errors (https://github.com/zombocom/wicked/pull/284)
 
 ## 1.4.0

lib/wicked/controller/concerns/render_redirect.rb

@@ -25,6 +25,8 @@ def process_resource!(resource, options = {})
       @skip_to ||= @next_step
     else
       @skip_to = nil
+      # Do not override user-provided status for render
+      options[:status] ||= :unprocessable_entity
     end
   end
 

test/controllers/status_codes_controller_test.rb

@@ -0,0 +1,18 @@
+require 'test_helper'
+
+class StatusCodesControllerTest < WickedControllerTestCase
+  test 'returns successful status code for show' do
+    get :show, params: { id: 'good' }
+    assert_response(:success)
+  end
+
+  test 'returns correct status code for successfuly update' do
+    put :update, params: { id: 'good' }
+    assert_response(:redirect)
+  end
+
+  test 'returns correct status code for failed update' do
+    put :update, params: { id: 'bad' }
+    assert_response(:unprocessable_entity)
+  end
+end

test/dummy/app/controllers/status_codes_controller.rb

@@ -0,0 +1,39 @@
+class StatusCodesController < ApplicationController
+  include Wicked::Wizard
+
+  class GoodThing
+    def save
+      true
+    end
+  end
+
+  class BadThing
+    def save
+      false
+    end
+  end
+
+  steps :good, :bad
+
+  def index; end
+
+  def show
+    render_wizard
+  end
+
+  def update
+    case step
+    when :good
+      @thing = GoodThing.new
+    when :bad
+      @thing = BadThing.new
+    end
+    render_wizard(@thing, notice: "Thing was updated from step #{step}.")
+  end
+
+  private
+
+  def finish_wizard_path
+    updates_path
+  end
+end

test/dummy/app/views/status_codes/bad.html.erb

@@ -0,0 +1 @@
+bad step

test/dummy/app/views/status_codes/good.html.erb

@@ -0,0 +1 @@
+good step

test/dummy/config/routes.rb

@@ -8,6 +8,7 @@
   resources :string_steps
   resources :redirect_to_next
   resources :redirect_to_finish_flash
+  resources :status_codes
   resources :updates
   resources :update_params