Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXES #287 - Add GitHub CI #288

Merged
merged 2 commits into from Aug 4, 2022
Merged

FIXES #287 - Add GitHub CI #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ab171
FIXES #287 - Add GitHub CI
deepakmahakale Aug 2, 2022
da98a49
Fix the breaking test cases by replacing attr_reader with attr_accessor
deepakmahakale Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
@@ -0,0 +1,53 @@
name: CI

on:
- push
- pull_request

jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
ruby:
- '2.5'
- '2.6'
- '2.7'
- '3.0'
- '3.1'
# - 'head'
gemfile:
- gemfiles/rails_5.2.gemfile
- gemfiles/rails_6.0.gemfile
# - gemfiles/rails_7.0.gemfile
# - gemfile: gemfiles/rails_head.gemfile
exclude:
# - ruby: '2.5'
# gemfile: gemfiles/rails_7.0.gemfile
# - ruby: '2.6'
# gemfile: gemfiles/rails_7.0.gemfile
- ruby: '2.7'
gemfile: gemfiles/rails_5.2.gemfile
- ruby: '3.0'
gemfile: gemfiles/rails_5.2.gemfile
- ruby: '3.0'
gemfile: gemfiles/rails_6.0.gemfile
- ruby: '3.1'
gemfile: gemfiles/rails_5.2.gemfile
- ruby: '3.1'
gemfile: gemfiles/rails_6.0.gemfile
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Set up Ruby
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run test
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
run: bundle exec rake test
17 changes: 0 additions & 17 deletions .travis.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rails_5.2.gemfile
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "~> 5.2"
gem "rails", "~> 5.2.0"

group :development, :test do
gem "sqlite3", platform: [:ruby, :mswin, :mingw]
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_5.1.gemfile → gemfiles/rails_6.0.gemfile
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "~> 5.2"
gem "rails", "~> 6.0"

group :development, :test do
gem "sqlite3", platform: [:ruby, :mswin, :mingw]
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_6.0.1.gemfile → gemfiles/rails_7.0.gemfile
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "~> 6.0.1"
gem "rails", "~> 7.0"

group :development, :test do
gem "sqlite3", platform: [:ruby, :mswin, :mingw]
Expand Down
2 changes: 1 addition & 1 deletion lib/wicked/wizard.rb
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ module Wizard
extend ActiveSupport::Concern

class InvalidStepError < RuntimeError
attr_reader :step
attr_accessor :step
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were failing with

Message: <"undefined method `step=' for #<Wicked::Wizard::InvalidStepError:0x000055e4b2713b48>">
---Backtrace---
/home/runner/work/wicked/wicked/lib/wicked/wizard.rb:9:in `initialize'
/home/runner/work/wicked/wicked/lib/wicked/wizard.rb:66:in `new'
/home/runner/work/wicked/wicked/lib/wicked/wizard.rb:66:in `setup_step_from'


def initialize(step = nil)
self.step = step
Expand Down