Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecs #5

Merged
merged 4 commits into from
Nov 12, 2018
Merged

Ecs #5

merged 4 commits into from
Nov 12, 2018

Conversation

zombre98
Copy link
Owner

@zombre98 zombre98 commented Nov 12, 2018 •
edited
Loading

Solve #3

@zombre98 zombre98 self-assigned this Nov 12, 2018
Valkyrihane
Valkyrihane requested changes Nov 12, 2018
View reviewed changes
Copy link
Collaborator

@Valkyrihane Valkyrihane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRR define should not be present

Vec3d is missing some methods

zombre98 and others added 2 commits November 12, 2018 16:33
@zombre98
Remove precompile define in GameContainer.hpp
5d8897a
Update vec.hpp
43cf054 
Added == and != overload methods for Vec3d
@Valkyrihane Valkyrihane merged commit a36194e into master Nov 12, 2018
@armandmgt armandmgt deleted the ecs branch November 12, 2018 16:58
@armandmgt armandmgt mentioned this pull request Nov 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valkyrihane Valkyrihane Valkyrihane approved these changes

Assignees

@zombre98 zombre98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zombre98 @Valkyrihane