Dominance joren #140
Merged
Dominance joren #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and fixed a typo in the description.
@zond There are two // comments in this, I'm not sure if Go can handle that. The 'default rule' actually overwrites the starting country rule. Let's keep it for now, but in a later stage we might find a solution for this. No need to wait with pushing this for this little feature. Same for the 'neutral' country - we currently can't colour countries neutral, and that's fine.
I'm okay with it, but we might want to revisit. It's really a lot of countries so a lot of centres are coloured at the start - but we might not want this amount of colouring. I'm quite okay with it, but let's see how a couple of matches go and tone it down a bit maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I added all the maps.
Next steps: