Long Names #86
Closed
Long Names #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added long names - Fixed two typos in SVG.
Added long names - Twenty twenty svg: fixed Hyderabad typo - Added long names for north sea wars/2020 - Copied classical to fleetrome/franceaustria
|
Sorry about the close/open, I pressed the wrong button. I noticed that you used Inkscape to change the typos on the maps - that's a bit dangerous, since Inkscape sometimes changes other things. I'll try to cherry pick the relevant changes... |
|
Alright, I cherrypicked all the long name things from your branch, but haven't touched the maps yet. |
|
Wallacia should be Wallachia (Google, only one is a land area)
…On Mon, 1 Jun 2020, 11:46 zond, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In variants/empiresandcoalitions/svg/empiresandcoalitionsmap.svg
<#86 (comment)>:
> @@ -4707,7 +4734,7 @@
style="font-weight:bold;stroke-width:0.26458329px"
id="tspan23176">Wa</tspan>ll<tspan
style="font-weight:bold;stroke-width:0.26458329px"
- id="tspan23180">a</tspan>cia</tspan></text>
+ id="tspan23180">a</tspan>chia</tspan></text>
And this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#86 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXURGLLKDAJYX24IS2YHZDRUN2HHANCNFSM4NPLMMRA>
.
|
|
Same here.
It's called balearic sea, not Balea
…On Mon, 1 Jun 2020, 11:46 zond, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In variants/empiresandcoalitions/svg/empiresandcoalitionsmap.svg
<#86 (comment)>:
> @@ -4278,7 +4305,7 @@
style="font-weight:bold;stroke-width:0.26458332px"
id="tspan23011">e</tspan><tspan
style="font-weight:normal;stroke-width:0.26458332px"
- id="tspan23013">a</tspan></tspan></text>
+ id="tspan23013">aric</tspan></tspan></text>
What are these changes?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#86 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXURGP4GOA5ZXC52XHP4ZTRUN2GVANCNFSM4NPLMMRA>
.
|
|
I made you a new pull request with separate spelling fixes.
…On Mon, Jun 1, 2020, 12:36 Joren ***@***.***> wrote:
Same here.
It's called balearic sea, not Balea
On Mon, 1 Jun 2020, 11:46 zond, ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In variants/empiresandcoalitions/svg/empiresandcoalitionsmap.svg
> <#86 (comment)>:
>
> > @@ -4278,7 +4305,7 @@
> style="font-weight:bold;stroke-width:0.26458332px"
> id="tspan23011">e</tspan><tspan
> style="font-weight:normal;stroke-width:0.26458332px"
> - id="tspan23013">a</tspan></tspan></text>
> + id="tspan23013">aric</tspan></tspan></text>
>
> What are these changes?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#86 (review)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABXURGP4GOA5ZXC52XHP4ZTRUN2GVANCNFSM4NPLMMRA
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#86 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB25MDXEFLBAINANSNRKLRUOADNANCNFSM4NPLMMRA>
.
|
Sea of Japan did not connect to all provinces. Updated the border, SoJ and East China Sea.
Forgot to put them back on non-visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added long names for all the maps.
Fixed typos in some of the map SVGs.