Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced NVD3 with Highcharts #146

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

whothisbeme
Copy link
Contributor

Also updated api.html and merged tbs.html into stats.html

@bluecircle
Copy link
Contributor

❤️

I've been hoping someone would get to doing this. Thanks so much for giving back to the project!

@eightsixeight
Copy link

doesnt work in IE / even in compat mode

also hangs quite a lot the graphics like the old one.

any change to see userstats per key ? or per address ?

thanks

@whothisbeme
Copy link
Contributor Author

@fcases Userstats per key/address is going to be added soon. I will update to support IE and graphics hanging could be due to the number of points selected to render, it defaults to one hour. If your updateInterval is set low this could cause hanging issues. I have noticed Highcharts very much more stable than NVD3 though.

@whothisbeme whothisbeme mentioned this pull request May 6, 2014
@LiveChains
Copy link

Worked a charm

@whothisbeme
Copy link
Contributor Author

edab056 should fix the issue where each pool's color would change when changing the time scale.

@eightsixeight
Copy link

mcpackin / on the edab056 fresh pull doesnt show graphs no more.. but on Improved compatibility with IE 2467f60 all was working.

@whothisbeme
Copy link
Contributor Author

@fcases Changed some of the code to hopefully work with capitalized Redis key names. Also fixed a bug when changing the time scale.

@crackfoo
Copy link
Contributor

is there anyway to get a wider selection of colours for the coins? If you have over 10, they are repeated and hard to distinguish which coin is which part of the graphs.

Thanks!

@whothisbeme
Copy link
Contributor Author

@crackfoo Yeah I can and will definitely add more colors! I have been fairly busy but I should be able to get this implemented by tomorrow

@sigwo
Copy link

sigwo commented Jun 2, 2014

Time to merge yet? These NVD3 charts....ugh.

@mapleshadow
Copy link

Please use the new code submission, submit your current code are outdated。
The latest code should be May 31 in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants