Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation of new dependencies #423

Closed
mattias-p opened this issue Apr 24, 2018 · 5 comments
Closed

Installation of new dependencies #423

mattias-p opened this issue Apr 24, 2018 · 5 comments

Comments

@mattias-p
Copy link
Member

JSON::Validator and Try::Tiny (or preferably their OS packages) should be added to the installation instruction.
@sandoche2k
Copy link
Contributor

@mattias-p for which OS?

@mattias-p
Copy link
Member Author

All of them. JSON::Validator and Try::Tiny are both listed in Makefile.PL, but none of the are listed in Installation.md.

@sandoche2k
Copy link
Contributor

I tried installing without JSON::Validator and Try::Tiny following the installation instructions on Debian. It works perfectly. In that case remove them from the Makefile.Pl? @mtoma @pamasse

@mattias-p
Copy link
Member Author

@sandoche2k It works because we have transitive dependencies to them as well as direct dependencies.

We should definitely keep all direct dependencies in Makefile.PL. Otherwise if our dependencies switch out their dependencies for whatever reason, installing Engine from CPAN will stop working all of a sudden.

We should list all direct dependencies in the installation instruction for analogous reasons.

@mattias-p
Copy link
Member Author

This was done long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattias-p @sandoche2k