Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debian installation instructions #700

Merged
7 commits merged into from Jan 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2021

This PR:

  • aligns locale generation with CLI installation document
  • apply relevant changes from Centos section to Debian (inspired from Update CentOS installation instruction #696)
  • install databases before configuring Zonemaster
  • fix incorrect option
  • fix database ownership

@ghost ghost requested review from mattias-p and matsduf January 27, 2021 11:25
@ghost ghost added this to the v2020.2 milestone Jan 27, 2021
@ghost ghost added the A-Documentation Area: Documentation only. label Jan 27, 2021
@matsduf matsduf added the P-High Priority: Issue to be solved before other label Jan 27, 2021
matsduf
matsduf previously approved these changes Jan 27, 2021
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@@ -376,9 +384,6 @@ sudo -u postgres psql -f $(perl -MFile::ShareDir -le 'print File::ShareDir::dist

#### 4.2.3 Instructions for SQLite (Debian)

> **Note:** Zonemaster with SQLite backend is not yet considered stable and anyway
> not meant for an installation with heavy load.
Copy link
Contributor

@matsduf matsduf Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should have the same statement -- or no statement -- for all OS. Should the statement that "Zonemaster with SQLite backend is not yet considered stable and anyway not meant for an installation with heavy load" be put somewhere else or not at all?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I removed it because this release brings a stable SQLite support. But indeed the second part of the note is still relevant.
I'll revert this specific commit and make a new PR to update this note in all sections.

@ghost
Copy link
Author

ghost commented Jan 27, 2021

Rebased on top of develop and removed commit cbb6ee6

@ghost ghost merged commit cde22c4 into zonemaster:develop Jan 27, 2021
@ghost ghost deleted the doc-install-debian branch January 27, 2021 14:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only. P-High Priority: Issue to be solved before other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant