Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fi_FI to supported languages in RPCAPI #712

Merged
merged 1 commit into from Apr 9, 2021

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Feb 12, 2021

Resolves issue #711 and assumes that zonemaster/zonemaster-engine#880 is merged.

Updated 2021-05-17:

How to test this PR

Change the language (with zmb) and check that we get Finnish messages.
Related to zonemaster/zonemaster-engine#880

@matsduf matsduf added the A-Translation Area: Documentation of, implementation of or actual translation of text label Feb 12, 2021
@matsduf matsduf added this to the v2021.1 milestone Feb 12, 2021
@matsduf matsduf requested review from mattias-p and a user February 12, 2021 17:14
@matsduf matsduf linked an issue Feb 13, 2021 that may be closed by this pull request
@matsduf matsduf changed the title Adds fi_FI to supported languages Adds fi_FI to supported languages in RPCAPI Feb 13, 2021
mattias-p
mattias-p previously approved these changes Feb 15, 2021
ghost
ghost previously approved these changes Feb 16, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@matsduf matsduf changed the base branch from master to develop March 17, 2021 14:42
@matsduf matsduf dismissed stale reviews from ghost and mattias-p March 17, 2021 14:42

The base branch was changed.

@matsduf matsduf requested review from mattias-p and a user March 17, 2021 14:46
@matsduf
Copy link
Contributor Author

matsduf commented Mar 17, 2021

Was created against wrong branch, master instead of develop. After that was change, is was rebased and force-pushed.

@matsduf matsduf merged commit 9e96c88 into zonemaster:develop Apr 9, 2021
@matsduf matsduf deleted the add-finnish-support branch April 9, 2021 19:47
@ghost
Copy link

ghost commented May 26, 2021

Release testing for v2021.1

I've verified this test procedure on Debian 10, Ubuntu 18.04 and Ubuntu 20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Finnish translation
2 participants