- Fix dnssec10 case when there are DNSKEY empty lists #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matsduf I did not changed levels of messages yet. This fix just prevents the engine to have a fatal error. |
ghost
mentioned this pull request
matsduf
approved these changes
Apr 4, 2022
matsduf
added
T-Bug
tgreenx
approved these changes
Apr 14, 2022
marc-vanderwal
added
the
S-ReleaseTested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes dnssec10 case when there are no DNSKEY availables but RRSIG exist. Which is possible during a "conservative" Key rollover (Knot does that, RRSIG are published before the keys)
Context
Fixes #1036
Changes
Changes in dnssec10 to prevent to do some tests when no DNSKEY is found.
How to test this PR
zonemaster-cli atiger.se --show-testcase --level error --test dnssec --raw
Recorded data is available in #1036.