replace moose with class accessor in Logger::Entry

[hannaeko]

Purpose

Remove Moose from Logger::Entry for better performance. The logger entries are objects that are instantiated a large number of time and which properties are accessed a lot during tests execution. In large batches having too much overhead in the methods involved can lead to performance issue. (I don't have the exact numbers anymore, those are things I tested last September but didn't get the chance to backport in mainline Zonemaster).

Context

• Continuation of a work started in Better performance by avoiding Moose #566
• Partially ported from https://gitlab.rd.nic.fr/zonemaster/zonemaster-engine/-/blob/nightly-ronde/lib/Zonemaster/Engine/Logger/Entry.pm

Changes

Replace Moose with Class::Accessor in Logger::Entry

How to test this PR

• Tests can be executed as usual: zonemaster-cli --level info zonemaster.net --show-module --show-testcase
• JSON generation is not impacted: zonemaster-cli --level info zonemaster.net --json

[mattias-p]

LGTM. But I have a question.

[matsduf]

@blacksponge, I am not a Moose fan, but if we replace Moose here with Class::Accessor should we then replace it with Class::Accessor everywhere? What do we win and what do we loose?

[hannaeko]

What do we win and what do we loose?

We remove some complex abstraction and it might improve performance in some case but we lose the abstraction / type checking and need to do that by hand if we still want it, meaning more boilerplate code.
Maybe moving away from Moose is a good idea, but I don't think it need to be a priority for the modules for which we will not see to substantial gain.

[matsduf]

I am fine with the change. I approve.