cache test level config in logger::entry

[hannaeko]

Purpose

Reduce the amount of time used cloning the test levels config.
Each call to Zonemaster::Engine::Profile->effective->get clone the result if it is not a scalar. For the test levels, this means that there will be a lot of calls to clone a fairly big hash. Here are the profiling info for a single test measured with PERL5OPT=-d:NYTProf ./zonemaster-cli --level info zonemaster.net --show-module --show-testcase.

	calls	exclusive time	inclusive time
	Zonemaster::Engine::Logger::Entry::level
before	5841	411ms	3390ms
after	5842	102ms	122ms
	Zonemaster::Engine::Profile::get
before	35873	361ms	3570ms
after	24838	245ms	726ms

Context

Ported from https://gitlab.rd.nic.fr/zonemaster/zonemaster-engine/-/blob/nightly-ronde/lib/Zonemaster/Engine/Logger/Entry.pm

Changes

• Cache the test levels for the time of the test

How to test this PR

Testing a domain should work as usual: ./zonemaster-cli --level info zonemaster.net --show-module --show-testcase

[ghost]

Nice improvement. Just a thought, do we really need to clone the data even once? Can't we just pass a ref around?

[mattias-p]

Just a thought, do we really need to clone the data even once? Can't we just pass a ref around?

I designed the Profile module interface to avoid leaking references to internal mutable data structures. The idea is that it'll make our lives easier.

[mattias-p]

Won't this break the ability to switch between profiles in Backend? Maybe reset_config() could be called from the "run" methods in Zonemaster::Engine::Test or something?

[matsduf]

Won't this break the ability to switch between profiles in Backend?

@blacksponge, has switching been tested?

See comment by @mattias-p.

[hannaeko]

Won't this break the ability to switch between profiles in Backend? Maybe reset_config() could be called from the "run" methods in Zonemaster::Engine::Test or something?

As the profile is only set in the child process this is not breaking profile switching. To be sure I tried to run two consecutive tests with different profile and it was correctly executed.

[matsduf]

I will re-review when the conflict has been resolved.

[hannaeko]

I have rebased on top of develop, please re-review

[matsduf]

I approve.