Fix breakage in Backend tests #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattias-p
changed the title
mattias-p
requested review from
matsduf,
hannaeko,
marc-vanderwal,
a user and
tgreenx
matsduf
approved these changes
May 18, 2022
| @@ -323,6 +324,8 @@ This method adds some fake delegation information to the system. | |||
| The arguments are a domain name, and a hashref with delegation information. | |||
| The keys in the hash are nameserver names, and the values are arrayrefs of IP | |||
| addresses for their corresponding nameserver. | |||
| Alternatively the IP addresses may be specified as an `undef` which is handled | |||
| the same as an empty arrayref. | |||
There was a problem hiding this comment.
Is "empty arrayref" correct in strict meaning? Shouldn't it be "reference to an empty array"?
ghost
approved these changes
May 18, 2022
tgreenx
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Context
Fixes a bug that was introduced in #1045.
Changes
Makes
undefan alias for[]in the arguments to add_fake_delegation().How to test this PR
Run the Backend unit tests using this version of Engine.