Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions for CentOS 7 #1080

Merged
2 commits merged into from May 24, 2022
Merged

Installation instructions for CentOS 7 #1080

2 commits merged into from May 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2022

Purpose

This reinstates installation instructions for CentOS 7 but with support for DNSSEC algos 15 and 16.

Context

based on zonemaster/zonemaster-ldns#134

Changes

New section for CentOS 7 in installation document with specific instruction to install Zonemaster::LDNS.

How to test this PR

Following the installation instruction should result in a properly working Zonemaster instance with support for DNSSEC algo 15 and 16.

With support for DNSSEC algos 15 and 16, installing openssl11-devel from
EPEL repositories.
@ghost ghost added this to the v2022.1 milestone May 23, 2022
@ghost ghost requested review from mattias-p, matsduf and hannaeko May 23, 2022 16:19
hannaeko
hannaeko previously approved these changes May 23, 2022
Copy link
Member

@hannaeko hannaeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by installing Zonemaster CLI on containerized Centos 7 and running zonemaster-cli --no-ipv6 --test DNSSEC --level info ed25519.nl, working fine.

Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update zonemaster/zonemaster#1060 to match the fact that algo 15 and 16 are supported.

Comment on lines +172 to +173
### Installation on CentOS 7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add something like

Please note! CentOS 7 will only be supported until the release of v2023.1, which is expected to happen during the spring of 2023. Consider Rocky Linux for an alternative Red Hat Linux derivative.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also encourage people to let us know what they're migrating to? Now, I don't expect anyone to actually make an effort to tell us. But I think it's good thing PR-wise to give people a feeling that we care about how they're using Zonemaster.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to address both comments.

sudo cpanm Module::Install::XSUtil MooseX::Singleton
```

4) Install Zonemaster::LDNS with DNSSEC 15 and 16 support:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNSSEC 15 and 16 -> DNSSEC algorithm 15 and 16?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install Zonemaster::LDNS with support for DNSKEY algorithms 15 and 16

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ghost ghost requested review from matsduf and mattias-p May 24, 2022 08:07
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost merged commit fc12c25 into zonemaster:develop May 24, 2022
@ghost ghost deleted the centos7-openssl branch October 17, 2022 16:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants