Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SOA values from Constants to profile #945

Closed
matsduf opened this issue Jul 21, 2021 · 4 comments · Fixed by #1032
Closed

Move SOA values from Constants to profile #945

matsduf opened this issue Jul 21, 2021 · 4 comments · Fixed by #1032
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented Jul 21, 2021

In Constants.pm the following SOA values are found:

Readonly our $SOA_DEFAULT_TTL_MAXIMUM_VALUE => 86_400;     # 1 day
Readonly our $SOA_DEFAULT_TTL_MINIMUM_VALUE => 300;        # 5 minutes
Readonly our $SOA_EXPIRE_MINIMUM_VALUE      => 604_800;    # 1 week
Readonly our $SOA_REFRESH_MINIMUM_VALUE     => 14_400;     # 4 hours
Readonly our $SOA_RETRY_MINIMUM_VALUE       => 3_600;      # 1 hour

Being there prevents the user from doing a simple policy change. It would be better to keep them in the policy.

The suggestion came from zonemaster/zonemaster#972.

@Ressy66
Copy link

Ressy66 commented Sep 22, 2021

ok after playing merry-go-rounds with all these issue numbers constantly redirecting all over the place, i'll ask here one more time, is this implemented, if so what is the filename/location that is edited for custom values, it really shouldnt be this hard.
or do we just keep editing constants which seems simplest for those who have found it

@matsduf
Copy link
Contributor Author

matsduf commented Sep 23, 2021

No, this is not yet implemented. There is not even a firm decision to have it implemented. I'm sorry, it will take some time.

As long as this issue is kept open it is not implemented. Any implementation will be done through a pull request that will be linked from this issue.

@ghost ghost mentioned this issue Dec 23, 2021
@matsduf
Copy link
Contributor Author

matsduf commented Dec 24, 2021

A proposal is found in #1032.

@ghost ghost linked a pull request Jan 4, 2022 that will close this issue
@ghost
Copy link

ghost commented Apr 11, 2022

Implemented with #1032

@ghost ghost closed this as completed Apr 11, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants