Create methods nt #656
Merged
Create methods nt #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The methods have be given descriptive names. * The methods have been split up so that only the needed data will be returned. * The specification of the methods is explicit. The goal is that nothing is assumed. * Also internal methods (to be used by other methods only) have been defined. * The goal is to replace the current methods.
matsduf
requested review from
mattias-p,
sandoche2k,
vlevigneron and
pamasse
Closed
mtoma
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the methods to be used by the test case descriptions.
These, new methods are defined in a new document planned to live side-by-side the current
methods until a test case specifications are rewritten to use the new methods.
This PR replaces #613.