Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update syntax06 #788

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Update syntax06 #788

merged 2 commits into from
Oct 4, 2019

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Jul 16, 2019 •
edited

Editorial updates (first commit 1fe2932):

  • No change of logic or text.
  • Corrected and consistent links
  • Spelling errors.
  • Does not affect implementation.

Updated mail logic and messages (second commit f7b92e8):

  • Explicit message for localhost as recipient.
  • Explicit message for illegal CNAME.
  • Explicit test all MX for RNAME and all must pass.
  • Raised default level of messages.
  • Affects implementation in several ways.

This PR resolves #776 and is related to zonemaster/zonemaster-engine#561.

When this PR is merged, an issue should be created in Zonemaster-Engine for updating the implementation.

@matsduf
Editorial updates
1fe2932 
* No change of logic or text.
* Corrected and consistent links
* Spelling errors.
@matsduf
Updated mail logic and messages
f7b92e8 
* Explicit message for localhost as recipient.
* Rxplicit message for illegal CNAME.
* Raised default level of messages.
@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Jul 16, 2019
@matsduf matsduf added this to the v2019.2 milestone Jul 16, 2019
@matsduf matsduf requested a review from sandoche2k July 16, 2019 15:37
@matsduf matsduf self-assigned this Jul 16, 2019
This was referenced Jul 16, 2019
Closed
Closed
@matsduf
Copy link
Contributor Author

matsduf commented Sep 19, 2019

Waiting for the review of @vlevigneron.

@matsduf matsduf merged commit c3f0574 into zonemaster:develop Oct 4, 2019
@matsduf matsduf deleted the update-syntax06 branch October 4, 2019 13:01
@matsduf matsduf mentioned this pull request Oct 4, 2019
Closed
@matsduf
Copy link
Contributor Author

matsduf commented Oct 10, 2019

Created issue zonemaster/zonemaster-engine#610 to have the change implemented.

@tgreenx tgreenx mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandoche2k sandoche2k sandoche2k approved these changes

@vlevigneron vlevigneron vlevigneron approved these changes

Assignees

@matsduf matsduf

Labels
A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Milestone
v2019.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matsduf @sandoche2k @vlevigneron