Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review GUI docs #811

Merged
merged 5 commits into from
Apr 6, 2020
Merged

Review GUI docs #811

merged 5 commits into from
Apr 6, 2020

Conversation

pamasse
Copy link
Contributor

@pamasse pamasse commented Oct 26, 2019

  • Change GUI to CLI which is the true subject of the behavior test for Behavior04

@pamasse
Copy link
Contributor Author

pamasse commented Oct 28, 2019

I review all tests, remove pointless tests or not related (check for correct domain name*).
I try to group tests with a little logic. First test the display and buttons of the GUI, then test forms and then test the result page.

Security tests are done in the backend.

@matsduf matsduf modified the milestones: v2019.2, v2019.3 Oct 29, 2019
sandoche2k
sandoche2k previously approved these changes Oct 31, 2019
@@ -13,14 +13,9 @@ defined in afnic.profile

### Results

The WEB-GUI seems to have taken into account of this functionality even though
The CLI seems to have taken into account of this functionality even though
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The Zonemaster-CLI has integrated this functionality even though"

Integrated Mats comments
@pamasse pamasse merged commit 84fe47a into zonemaster:develop Apr 6, 2020
tgreenx pushed a commit to tgreenx/zonemaster that referenced this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants