Allow creating the dist file on older OSes #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this for v2019.2? |
matsduf
requested changes
Nov 18, 2019
| @@ -62,7 +62,7 @@ listed changes are covered by MANIFEST.SKIP: | |||
|
|
|||
| For all components, generate Makefile, META.yml and others. | |||
|
|
|||
| perl Makefile.PL | |||
| perl Makefile.PL --no-ed25519 | |||
There was a problem hiding this comment.
The --no-ed25519 is only relevant for Zonemaster-LDNS. Have different commands or at least document that the flag is ignored for all other components.
matsduf
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820.