Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specification of issue labels #824

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Specification of issue labels #824

merged 3 commits into from
Nov 21, 2019

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Nov 15, 2019

This is a specification of the labels that we agreed on 2019-11-13 on the F2F meeting. Some comments on my proposal:

  • The colon in the label is replaced by a hyphen since the search interface uses colon as a meta character.
  • The space character has been removed to make it easier to write them when searching and "camel case" has been used to make it easier to read them. When searching for issues by label the search interface is case insensitive.
  • The label "S-ProposalExists" was added.
  • For each label there is a short description.
  • All repositories will have the same labels with the same colors to make it uniform, except that some labels will only exist some repositories.

Please comment!

I set the milestone to v2019.2 since I plan to implement it as soon as possible.

@matsduf matsduf added this to the v2019.2 milestone Nov 15, 2019
@matsduf
Copy link
Contributor Author

matsduf commented Nov 18, 2019

I have implemented the relevant labels in the Zonemaster/Zonemaster repository:

https://github.com/zonemaster/zonemaster/labels

@matsduf matsduf closed this Nov 18, 2019
@matsduf matsduf reopened this Nov 18, 2019
@matsduf matsduf added A-Documentation Area: Documentation only. T-Project labels Nov 18, 2019
mattias-p
mattias-p approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it works out!

docs/internal-documentation/maintenance/IssueLabels.md
main | In the table above, "main" stands for the [Zonemaster/Zonemaster] repository
Backend | In the table above, "Backend" stands for the [Zonemaster-Backend] repository
Engine | In the table above, "Engine" stands for the [Zonemaster-Engine] repository
red | Label with color code #EE0701
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the specification of RGB values :)

@matsduf matsduf merged commit 59c30df into zonemaster:develop Nov 21, 2019
@matsduf matsduf deleted the create-issue-label-spec branch November 21, 2019 08:48
tgreenx pushed a commit to tgreenx/zonemaster that referenced this pull request Jan 3, 2022
@matsduf
Merge pull request zonemaster#824 from matsduf/translate-danish
aa038f7 
Translation update (Danish)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattias-p mattias-p mattias-p approved these changes

@sandoche2k sandoche2k sandoche2k approved these changes

@mtoma mtoma Awaiting requested review from mtoma

@vlevigneron vlevigneron Awaiting requested review from vlevigneron

@pamasse pamasse Awaiting requested review from pamasse

Assignees
No one assigned
Labels
A-Documentation Area: Documentation only.
Projects
None yet
Milestone
v2019.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matsduf @mattias-p @sandoche2k