Updated treatment of DS SHA-1 in DNSSEC01 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an initial comment on the status of SHA-1 * Created new message tag * Set default level to WARNING (instead of ERROR) ERROR was felt to be too harsh due to the wide use, and due to the fact that SHA-1 based DNSSEC algorithms only create WARNING as default.
* Sorted link list. * Updated indentation in link list.
matsduf
added
A-TestCase
sandoche2k
approved these changes
Apr 15, 2020
| The table of algorithms below is for reference only and is copied from [IANA | ||
| At the time of writing (2020-04-08), algorithm 1 (SHA-1) is still | ||
| in wide use even though it is no longer considered to be secure | ||
| ([Wikipedia]). |
There was a problem hiding this comment.
Is Wikipedia a reliable reference?
There was a problem hiding this comment.
Yes, Wikipedia has good checks of the content.
mattias-p
approved these changes
Apr 15, 2020
|
@vlevigneron, can you also review? |
vlevigneron
approved these changes
Apr 16, 2020
tgreenx
pushed a commit
to tgreenx/zonemaster
that referenced
this pull request
Jan 3, 2022
Merge develop into master (Engine), second time
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERROR was felt to be too harsh due to the wide use, and due to the
fact that SHA-1 based DNSSEC algorithms only create WARNING as
default. Secondly, IANA still lists SHA-1 as algorithm to be used for DS.
Commit 1: Updated the treatment of algo 1 (SHA-1)
Commit 2: Removed trailing spaces
Commit 3:
When this PR has been approved and merged, a new issue will be created in Zonemaster-Engine for the implementation to be updated.