Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior when exporting ![[image.svg]] vs ![[image.png]] #42

Closed
nsainaney opened this issue Sep 21, 2021 · 4 comments · Fixed by #43
Closed

Inconsistent behavior when exporting ![[image.svg]] vs ![[image.png]] #42

nsainaney opened this issue Sep 21, 2021 · 4 comments · Fixed by #43

Comments

@nsainaney
Copy link
Contributor

nsainaney commented Sep 21, 2021

Hi there,
Great library! It's exactly what we needed.

I have a source file with:

![[CLI.svg]]
![[CLI.png]]

and the exported file results in:

[CLI.svg](_fragments/_gen_media/CLI.svg)
![CLI.png](_fragments/_gen_media/CLI.png)

The svg is missing the exclamation mark. I'd love to be able to submit a PR however, I've never done any rust coding. Would appreciate a fix or direction on where this fix would need to be.

Thanks!

> obsidian-export --version
obsidian-export 21.9.0
@zoni
Copy link
Owner

zoni commented Sep 22, 2021

Hey @nsainaney, the list of extensions that are treated as embeddable images is defined here:

Some("png") | Some("jpg") | Some("jpeg") | Some("gif") | Some("webp") => {

Just adding an extra Some("svg") match clause there would be sufficient. I think that would be totally reasonable, so if you make a PR I'll happily merge and make a new version 😄

@nsainaney
Copy link
Contributor Author

Hi @zoni ,
Any chance this can be published to crates.io? We have our CI/CD pipelines using obsidian-export and it'd be nice to get this working.

Thanks!

@zoni
Copy link
Owner

zoni commented Sep 24, 2021

I'll happily accept coffee bribes to speed up reviews and new releases. 😉

@zoni zoni closed this as completed in #43 Sep 24, 2021
@zoni
Copy link
Owner

zoni commented Sep 24, 2021

New release is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants