Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q]: Any plans to update testcontainers? #260

Closed
superdrenner opened this issue Feb 13, 2024 · 5 comments
Closed

[Q]: Any plans to update testcontainers? #260

superdrenner opened this issue Feb 13, 2024 · 5 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@superdrenner
Copy link

Are there any plans to update to the latest version of testcontainers-java? Newer versions support DOCKER_AUTH_CONFIG environment variables which would be really nice to have.

@tomix26
Copy link
Collaborator

tomix26 commented Feb 14, 2024

Are you facing any specific problem? Because I tried upgrading the version manually in a demo project and it worked fine, even with the newest versions of Testcontainers. So, if there's a specific error, could you please attach the log here? It would give me a better idea of where the problem might be.

@tomix26 tomix26 added the status: waiting-for-feedback We need additional information before we can continue label Feb 14, 2024
@superdrenner
Copy link
Author

@tomix26 I'm not having a problem, I would just like to not have to override the version of testcontainers when using Zonky. Testcontainers 1.17 is a few years old and they've added new features since that release.

@tomix26
Copy link
Collaborator

tomix26 commented Feb 14, 2024

You don't need to override the version of testcontainers when using the zonky database, as the current version 1.17.6 already supports all the features required by the library. New features, such as the DOCKER_AUTH_CONFIG variable, are not essential for its proper functioning, and the library cannot take advantage of them.

Furthermore, there's a reason to be cautious about upgrading to the latest versions too quickly. Doing so could lead to version conflicts in version management systems like Gradle, which selects the highest version available in the dependency tree. This might cause compatibility issues with other libraries that depend on the same but older versions of a dependency.

Therefore, if there's a real reason to upgrade (due to compatibility issues, vulnerabilities, etc.), please let me know, and I'll be happy to upgrade it. Otherwise, I'd prefer to keep the versions slightly behind to avoid potential issues. This conservative approach is also applied to Spring and other dependencies.

In the next major update, I could redefine all these dependencies as runtime dependencies to ensure better separation from the target projects. This would mean that if you wanted to use testcontainers in your project for your business, you would have to explicitly define the dependency with the version you need. Now you should be doing the same, but it's not so obvious.

@tomix26 tomix26 added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 14, 2024
@superdrenner
Copy link
Author

DOCKER_AUTH_CONFIG works automatically when I override the version of testcontainers. People who use Gitlab actually need to use that variable for testcontainers to function properly.

Being cautions is one thing but using dependencies that are years behind is another. Spring Boot 3 will be out soon and there is also Spring 6, will those not be supported for years too?

@tomix26
Copy link
Collaborator

tomix26 commented Feb 15, 2024

You can always upgrade to the required version manually. The library contains a lot of tests guaranteeing runtime compatibility with newer versions as well. They are just not chosen as the default ones. Cheers.

tomix26 added a commit that referenced this issue Apr 9, 2024
tomix26 added a commit that referenced this issue Apr 9, 2024
@tomix26 tomix26 added this to the 2.5.1 milestone Apr 9, 2024
@tomix26 tomix26 closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

2 participants