#4 Enable optional postgis extensions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomix26
requested changes
May 10, 2019
|
All comments should be resolved. The typo and Dockerfile were part of my initial explorations with postgis here, sorry for leaving them in! |
Configure build and deployment of secondary artifacts containing PostGIS extension, by specifying "-PpostgisVersion=x.y.z" during the build.
|
During the testing, I made some minor changes and fixes. For example, I had to remove the postgis classifier, because otherwise Maven resolves it as a completely different dependency and it is difficult to override the original postgres dependencies. So now the postgis extension is part of the version of the postgres binaries, such as |
tomix26
approved these changes
May 26, 2019
|
Thanks again for your contribution. |
|
Excellent! Thanks very much! |
tomix26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure build and deployment of secondary artifacts with a "postgis"
classifier, by specifying "-PpostgisVersion=x.y.z" during the build.
Fixes #4