Merge pull request #26 from zonkyio/native-array-prototype-includes

Use native Array.prototype.includes
zonkyio · Dec 26, 2018 · ebfdf27 · ebfdf27
2 parents 06fd47e + 8065b66
commit ebfdf27
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 40 deletions.
diff --git a/lib/generate-browserconfig-from-configuration.js b/lib/generate-browserconfig-from-configuration.js
@@ -4,7 +4,6 @@ module.exports = generateBrowserconfigFromConfiguration;
 
 const xmlbuilder = require('xmlbuilder');
 const hasTarget = require('./has-target');
-const includes = require('./utils/includes');
 
 const ALLOWED_ICON_ELEMENTS = [
   'square70x70logo',
@@ -40,7 +39,7 @@ function constructTile(icons, color) {
   const tile = {};
 
   icons.forEach(function(icon) {
-    if (!includes(ALLOWED_ICON_ELEMENTS, icon.element)) {
+    if (!ALLOWED_ICON_ELEMENTS.includes(icon.element)) {
       throw new Error(`The 'element' property of the icon for browserconfig.xml must be one of ${ALLOWED_ICON_ELEMENTS.join(', ')}`);
     }
 

diff --git a/lib/utils/includes.js b/lib/utils/includes.js
diff --git a/node-tests/unit/utils/includes-test.js b/node-tests/unit/utils/includes-test.js