Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slashes from HTML snippets #344

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Remove trailing slashes from HTML snippets #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/dummy/app/templates/docs/advanced/using-cors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

You can specify `crossorigin` behaviour for `manifest.webmanifest` by updating the `app/index.html` file.

```
```html
<link
rel="manifest"
href="{{rootURL}}manifest.webmanifest"
crossorigin="use-credentials"
/>
>
```

_See [Mozilla's Documentation](https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_settings_attributes) for more details._
6 changes: 3 additions & 3 deletions tests/dummy/app/templates/docs/getting-started/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ ember install ember-web-app

Ember should install the addon, add a `config/manifest.js` file, and insert HTML tags for `manifest.webmanifest` and `browserconfig.xml` into `app/index.html` file.

```
```html
<head>
<link rel="manifest" href="{{rootURL}}manifest.webmanifest" />
<meta name="msapplication-config" content="{{rootURL}}browserconfig.xml" />
<link rel="manifest" href="{{rootURL}}manifest.webmanifest">
<meta name="msapplication-config" content="{{rootURL}}browserconfig.xml">
</head>
```

Expand Down
8 changes: 4 additions & 4 deletions tests/dummy/app/templates/docs/getting-started/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ From [MDN](https://developer.mozilla.org/en-US/docs/Web/Manifest)

The generated `manifest.webmanifest` file is linked to the application using `link` tag in `app/index.html` file.

```
<link rel="manifest" src="{{rootURL}}manifest.webmanifest" />
```html
<link rel="manifest" src="{{rootURL}}manifest.webmanifest">
```

_The generated manifest is validated using `web-app-manifest-validator` package._
Expand All @@ -27,8 +27,8 @@ From [Microsoft](https://msdn.microsoft.com/en-us/library/dn320426%28v=vs.85%29.

The generated `browserconfig.xml` file is linked to the application using `meta` tag in `app/index.html` file.

```
<meta name="msapplication-config" content="{{rootURL}}browserconfig.xml" />
```html
<meta name="msapplication-config" content="{{rootURL}}browserconfig.xml">
```

_You can skip generating of `browserconfig.xml` file by removing the `meta` tag from the `app/index.html` file._
Expand Down