Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5.16.10.17706 #3

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

wilkinson4
Copy link
Contributor

No description provided.

@mieszko4 mieszko4 merged commit 02bb812 into zoom-us-community:master Dec 15, 2023
@mieszko4
Copy link
Contributor

I had to rebuild it because there was already broken tag. The rebuild tag is 5.16.10.17707

@wilkinson4
Copy link
Contributor Author

I had to rebuild it because there was already broken tag. The rebuild tag is 5.16.10.17707

Seems like there are some issues with the assets available in the new version in Jitpack. Did I miss something in my PR, or is this something similar to this issue
Screenshot 2023-12-15 at 12 27 54 PM
Screenshot 2023-12-15 at 12 29 21 PM
Screenshot 2023-12-15 at 12 29 51 PM

@mieszko4
Copy link
Contributor

Builds for me.
I did the following changes in mieszko4/react-native-zoom-us#314:

diff --git a/android/build.gradle b/android/build.gradle
index 0338454..1aa0bbe 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -36,7 +36,7 @@ android {
 dependencies {
     implementation 'com.facebook.react:react-native:+' // From node_modules
 
-    implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.16.2.16555'
+    implementation 'com.github.zoom-us-community:jitpack-zoom-us:5.16.10.17707'
 
     // Dependencies copied from mobilertc-android-studio/mobilertc/build.gradle
     // NB: We use com.google.android.flexbox:flexbox:3.0.0 because of "Could not find com.google.android:flexbox:2.0.1"
diff --git a/android/src/main/java/ch/milosz/reactnative/RNZoomUsModule.java b/android/src/main/java/ch/milosz/reactnative/RNZoomUsModule.java
index 6b29304..9c3d51e 100644
--- a/android/src/main/java/ch/milosz/reactnative/RNZoomUsModule.java
+++ b/android/src/main/java/ch/milosz/reactnative/RNZoomUsModule.java
@@ -1128,6 +1128,10 @@ public class RNZoomUsModule extends ReactContextBaseJavaModule implements ZoomSD
   public void onLocalRecordingPrivilegeRequested(IRequestLocalRecordingPrivilegeHandler handler) {}
   @Override
   public void onRequestLocalRecordingPrivilegeChanged(LocalRecordingRequestPrivilegeStatus status) {}
+  @Override
+  public void onParticipantProfilePictureStatusChange(boolean hidden) {};
+  @Override
+  public void onAICompanionActiveChangeNotice(boolean active) {};
 
   // InMeetingShareListener event listeners
   // DEPRECATED: onShareActiveUser is just kept for now for backwards compatibility of events

And updated ndkVersion = "25.2.9519653"

@wilkinson4 wilkinson4 deleted the ww/5.16.10.17706 branch December 15, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants