Add change-password form #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| {if @state.inProgress | ||
| <i className="fa fa-spinner fa-spin form-help"></i> | ||
| else if @state.success |
There was a problem hiding this comment.
Nitpicky, but @state.success is never used, due to having to signOut/signIn to get a new session.
There was a problem hiding this comment.
I'd actually like to leave this. The real issue is that the auth modules needs to sign out and back in. There might be a way around that, but I don't think it's worth investing too much time in right now.
|
Other than the above comment, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to change their passwords from the settings page
Closes #333.