Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run npm update #4933

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Run npm update #4933

merged 1 commit into from
Oct 1, 2018

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Sep 26, 2018

Bump patch versions of

  • babel-loader
  • coffeescript
  • marked
  • rc-slider
  • styled-components

Staging branch URL: https://npm-update.pfe-preview.zooniverse.org/

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@coveralls
Copy link

coveralls commented Sep 26, 2018

Coverage Status

Coverage remained the same at 43.634% when pulling a94491a on npm-update into 7dd2a65 on master.

Bump patch versions of
 - babel-loader
 - coffeescript
 - marked
 - rc-slider
 - styled-components
@eatyourgreens eatyourgreens merged commit 5545e9e into master Oct 1, 2018
@eatyourgreens eatyourgreens deleted the npm-update branch October 1, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants