Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResizeObserver message to ignoreErrors option #2047

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Feb 23, 2021

Please request review from @zooniverse/frontend team. If PR is related to design, please request review from @beckyrother in addition.

Package: app-projects, app-content-pages

I've set Sentry to ignore the ResizeObserver error message. This is benign according to the spec authors and there's an open issue to change it to be a warning. See: WICG/resize-observer#38

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?

Components

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you yarn panic && yarn bootstrap or docker-compose up --build and app works as expected?

Publishing

  • Is the changelog updated?
  • Are the dependencies updated for apps and libraries that are using the newly published library?

Post-merging

@srallen srallen added the dx Things that improve the developer experience label Feb 23, 2021
@srallen srallen requested a review from a team February 23, 2021 17:10
@srallen srallen added this to To do in Project app via automation Feb 23, 2021
@github-actions github-actions bot added the approved This PR is approved for merging label Feb 23, 2021
@srallen srallen merged commit 50ad097 into master Feb 23, 2021
Project app automation moved this from To do to Done Feb 23, 2021
@srallen srallen deleted the filter-resize-error branch February 23, 2021 18:37
@eatyourgreens eatyourgreens mentioned this pull request Dec 8, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging dx Things that improve the developer experience
Projects
Project app
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants