Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classifier: Custom Video Controls #3684

Merged
merged 41 commits into from
Oct 10, 2022
Merged

Classifier: Custom Video Controls #3684

merged 41 commits into from
Oct 10, 2022

Commits on Sep 12, 2022

  1. Prepare SingleVideoViewer for adding unit tests 

    - Remove defaultProps
- Rename some variables for clarity
- Add Readme info
    @goplayoutside3
    goplayoutside3 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    838c5eb View commit details
    Browse the repository at this point in the history

  2. clean up a bit

    @goplayoutside3
    goplayoutside3 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f2e15e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. create default storybook for SingleVideoViewerContainer

    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5ad95ce View commit details
    Browse the repository at this point in the history

  2. working toward handling loading states 

    - install @storybook/testing-react
- delete SingleVideoViewerConnector
    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2f61ab3 View commit details
    Browse the repository at this point in the history

  3. more renaming for clarity

    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6d0d984 View commit details
    Browse the repository at this point in the history

  4. refactor SingleVideoViewerContainer as a functional component

    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    0f1feb1 View commit details
    Browse the repository at this point in the history

  5. add translation to SubjectViewer and unit tests for SingleVideoViewer… 

    …Container
    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    d49c09e View commit details
    Browse the repository at this point in the history

  6. add SingleVideoViewer unit test

    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6735ede View commit details
    Browse the repository at this point in the history

  7. clean up SingleVideoViewerContainer's readme

    @goplayoutside3
    goplayoutside3 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    7be841c View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. use ternary for videoSrc in SingleVideoViewerContainer

    @goplayoutside3
    goplayoutside3 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    9458a80 View commit details
    Browse the repository at this point in the history

  2. only render the drawing tools interaction layers when enableDrawing i… 

    …s true
    @goplayoutside3
    goplayoutside3 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    36c692a View commit details
    Browse the repository at this point in the history

  3. Remove FormattedTime and defaultProps

    @goplayoutside3
    goplayoutside3 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    fec8ad3 View commit details
    Browse the repository at this point in the history

  4. combine Slider component into VideoController file

    @goplayoutside3
    goplayoutside3 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c5f371a View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Working toward imporoving VideoController performance

    @goplayoutside3
    goplayoutside3 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    610c073 View commit details
    Browse the repository at this point in the history

  2. memoize ReactPlayer for slider performance

    @goplayoutside3
    goplayoutside3 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    249a303 View commit details
    Browse the repository at this point in the history

  3. clean up formatTimeStamp and its unit tests

    @goplayoutside3
    goplayoutside3 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    96f36b8 View commit details
    Browse the repository at this point in the history

  4. getFixedNumber unit tests and docs

    @goplayoutside3
    goplayoutside3 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    720cae4 View commit details
    Browse the repository at this point in the history

  5. handle invalid inputs to getFixedNumber() and formatTimeStamp()

    @goplayoutside3
    goplayoutside3 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    8b9af19 View commit details
    Browse the repository at this point in the history

  6. handle playback rate label

    @goplayoutside3
    goplayoutside3 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d9e5729 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. add unit tests for VideoController

    @goplayoutside3
    goplayoutside3 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    e8cc4d6 View commit details
    Browse the repository at this point in the history

  2. create custom theme for VideoController

    @goplayoutside3
    goplayoutside3 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    5d62695 View commit details
    Browse the repository at this point in the history

  3. add volume and fullscreen controls

    @goplayoutside3
    goplayoutside3 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    f8454ae View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. build custom volume range input

    @goplayoutside3
    goplayoutside3 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    73dd3c0 View commit details
    Browse the repository at this point in the history

  2. fix grid styling of video controls

    @goplayoutside3
    goplayoutside3 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    49261f6 View commit details
    Browse the repository at this point in the history

  3. clean up and add more unit tests

    @goplayoutside3
    goplayoutside3 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    1366596 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into single-video-viewer-upgrade

    @goplayoutside3
    goplayoutside3 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    50d9211 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'single-video-viewer-upgrade'

    @goplayoutside3
    goplayoutside3 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    e7d5caf View commit details
    Browse the repository at this point in the history

  6. fix typo

    @goplayoutside3
    goplayoutside3 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    06b7480 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Merge branch 'master'

    @goplayoutside3
    goplayoutside3 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    940f707 View commit details
    Browse the repository at this point in the history

  2. clean up merge from 'master'

    @goplayoutside3
    goplayoutside3 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    33d0fc0 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Merge branch 'master'

    @goplayoutside3
    goplayoutside3 committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    16ded41 View commit details
    Browse the repository at this point in the history

  2. fix missing import

    @goplayoutside3
    goplayoutside3 committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    0e32db1 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Merge branch 'master' into video-controller-refactor

    @goplayoutside3
    goplayoutside3 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    6652812 View commit details
    Browse the repository at this point in the history

  2. fix small typo in SingleVideoViewer's README 

    Co-authored-by: Shaun A. Noordin <shaunanoordin@users.noreply.github.com>
    @goplayoutside3 @shaunanoordin
    goplayoutside3 and shaunanoordin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    afc2bfe View commit details
    Browse the repository at this point in the history

  3. implement change suggestions from PR review

    @goplayoutside3
    goplayoutside3 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c8be69a View commit details
    Browse the repository at this point in the history

  4. Update README of formatTimeStamp() 

    Co-authored-by: Shaun A. Noordin <shaunanoordin@users.noreply.github.com>
    @goplayoutside3 @shaunanoordin
    goplayoutside3 and shaunanoordin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    a5e3544 View commit details
    Browse the repository at this point in the history

  5. update grammar of formatTimeStamp() README 

    Co-authored-by: Shaun A. Noordin <shaunanoordin@users.noreply.github.com>
    @goplayoutside3 @shaunanoordin
    goplayoutside3 and shaunanoordin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    f6902d7 View commit details
    Browse the repository at this point in the history

  6. add ADR 45 + custom controls only display with drawing tools enabled

    @goplayoutside3
    goplayoutside3 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    47420a0 View commit details
    Browse the repository at this point in the history

  7. add more stories and unit tests to SingleVideoViewerContainer

    @goplayoutside3
    goplayoutside3 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    134c203 View commit details
    Browse the repository at this point in the history

  8. Resolve package.json conflict with master

    @goplayoutside3
    goplayoutside3 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    ae7d50f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into video-controller-refactor

    @goplayoutside3
    goplayoutside3 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    191fcad View commit details
    Browse the repository at this point in the history