Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook and Sentry to consistent versions across packages #5965

Closed
wants to merge 3 commits into from

Conversation

goplayoutside3
Copy link
Contributor

Package

all

Linked Issue and/or Talk Post

Closes: #5918

Describe your changes

Used yarn upgrade-interactive to bump Storybook packages to 7.6.17 and sentry/browser to its latest version (the sentry/next version was just bumped here #5961)

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out

Maintenance

  • If not from dependabot, the PR creator has described the update (major, minor, or patch version, changelog)

@goplayoutside3 goplayoutside3 added the dependencies Pull requests that update a dependency file label Mar 14, 2024
@goplayoutside3
Copy link
Contributor Author

Ran into this bug while upgrading Storybook dependencies 😢 Looks like we need to upgrade Yarn soon!

string-width dependency stops storybook from executing: storybookjs/storybook#22431

@goplayoutside3
Copy link
Contributor Author

Ugh nevermind I'm going to close this in favor of upgrading FEM's yarn version because yarn v1 is not supported by the newest Storybook v8.

@goplayoutside3 goplayoutside3 mentioned this pull request Mar 14, 2024
6 tasks
@goplayoutside3 goplayoutside3 deleted the sentry-storybook-upgrades branch April 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched packages for Sentry and Storybook
1 participant