-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's a User? #40
Comments
Also: is sorta an issue-per-model a good way to talk about what's associated with what and what's returned with which requests? |
Yeah that sounds good me. I'd be fine with using people's logins since they're already case insensitive. Do we currently permit white-space? I'd like to not have to have %20s all over URLs |
Login names have spaces and other chars currently with validation only on uniqueness (case_insensitive) and presence. I confirmed there are users in home with spaces in their logins. |
What if we silently convert whitespaces to underscores? Persist "cool user" as "cool_user", and when she tries to login do a |
Yeah, we could even enforce no spaces for new users / updates to login names and use something like Ed suggested for migrated users |
What about "¢øø£ usér" though? |
I don't think this is a big deal by the way. Maybe we disallow spaces, but I'd hate to tell people they can't use accented characters. I think the number of weird characters in accounts and the number of people who actually look at URLs is small enough that we don't need to worry about this. |
I'm cool with allowing any characters that don't have to be escaped to be
|
+1 for not escaping chars in URL's. |
"cool user" and "cool_user" can both exist in the database right now. That's not going to work.
I'm up for setting sane validations for new users. I'm just not sure how we can force changes to old users. I'd love to get rid of some of the crazy values in that table though. If you're up for a laugh, go take a look at some of the weird junk in there. |
@parrish brought this up at Standup today. What kind of user logins will we allow? I'm for downcased and no whitespace, but otherwise anything goes. When a migrated user signs on, we just prompt them to change their login name, while leaving their display name set to their old user name. |
I think a set of restricted characters is fine too. At least |
Have we given up on shifting to allowing Facebook/Twitter/whatever logins? We’ve had that on our desirables list for a long while now. On 15 Jan 2015, at 08:21, Michael Parrish notifications@github.com wrote:
|
Nope already support Facebook and google+ logins. We don't have twitter at
|
Remove login attribute from user model. Restrict user names to not allow whitespace or the characters ($,@). Closes zooniverse#544, Closes zooniverse#40
Currently a user signs up with:
In #38 @edpaget suggested a separate key for URL. That gives us three "name" properties. Can we use the login for the URL, encoding what needs encoding when calling the API? URLs in the browser should render okay: #/ß®ï@ñ-¢.
The text was updated successfully, but these errors were encountered: