DX: fix checking test class extends PhpCsFixer\Tests\TestCase (PHP-…

…CS-Fixer#7567)
zoonru · Feb 2, 2024 · 0579e57 · 0579e57
1 parent 493ed21
commit 0579e57
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/tests/AutoReview/ComposerFileTest.php b/tests/AutoReview/ComposerFileTest.php
@@ -14,7 +14,7 @@
 
 namespace PhpCsFixer\Tests\AutoReview;
 
-use PHPUnit\Framework\TestCase;
+use PhpCsFixer\Tests\TestCase;
 
 /**
  * @internal

diff --git a/tests/AutoReview/DocumentationTest.php b/tests/AutoReview/DocumentationTest.php
@@ -21,17 +21,14 @@
 use PhpCsFixer\Fixer\FixerInterface;
 use PhpCsFixer\FixerFactory;
 use PhpCsFixer\RuleSet\RuleSets;
-use PHPUnit\Framework\TestCase;
+use PhpCsFixer\Tests\TestCase;
 use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
 use Symfony\Component\Finder\Finder;
 
 /**
  * @internal
  *
- * @covers \PhpCsFixer\Documentation\DocumentationLocator
- * @covers \PhpCsFixer\Documentation\FixerDocumentGenerator
- * @covers \PhpCsFixer\Documentation\RstUtils
- * @covers \PhpCsFixer\Documentation\RuleSetDocumentationGenerator
+ * @coversNothing
  *
  * @group legacy
  * @group auto-review

diff --git a/tests/AutoReview/ProjectCodeTest.php b/tests/AutoReview/ProjectCodeTest.php
@@ -98,7 +98,6 @@ public function testThatSrcClassHaveTestClass(string $className): void
         }
 
         self::assertTrue(class_exists($testClassName), sprintf('Expected test class "%s" for "%s" not found.', $testClassName, $className));
-        self::assertTrue(is_subclass_of($testClassName, TestCase::class), sprintf('Expected test class "%s" to be a subclass of "\PhpCsFixer\Tests\TestCase".', $testClassName));
     }
 
     /**
@@ -199,6 +198,14 @@ public function testThatSrcClassesNotExposeProperties(string $className): void
         );
     }
 
+    /**
+     * @dataProvider provideTestClassCases
+     */
+    public function testThatTestClassExtendsPhpCsFixerTestCaseClass(string $className): void
+    {
+        self::assertTrue(is_subclass_of($className, TestCase::class), sprintf('Expected test class "%s" to be a subclass of "%s".', $className, TestCase::class));
+    }
+
     /**
      * @dataProvider provideTestClassCases
      */
@@ -848,7 +855,7 @@ private static function getTestClasses(): array
 
         $finder = Finder::create()
             ->files()
-            ->name('*.php')
+            ->name('*Test.php')
             ->in(__DIR__.'/..')
             ->exclude([
                 'Fixtures',
@@ -865,8 +872,6 @@ private static function getTestClasses(): array
             iterator_to_array($finder, false)
         );
 
-        $classes = array_filter($classes, static fn (string $class): bool => is_subclass_of($class, TestCase::class));
-
         sort($classes);
 
         return $classes;