Updated Android permissions adding all missing Android permissions. #232
Conversation
| event: PermissionsAndroid.PERMISSIONS.READ_CALENDAR, | ||
| writeEvent: PermissionsAndroid.PERMISSIONS.WRITE_CALENDAR, | ||
| accounts: PermissionsAndroid.PERMISSIONS.GET_ACCOUNTS, | ||
| readStorage: PermissionsAndroid.PERMISSIONS.READ_EXTERNAL_STORAGE, | ||
| storage: PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE, | ||
| photo: PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE, |
There was a problem hiding this comment.
@yonahforst should this be asking for READ_EXTERNAL_STORAGE instead of WRITE_EXTERNAL_STORAGE?
There was a problem hiding this comment.
It probably should be. I didn't touch any existing code because I didn't want to make any breaking changes. I just added the remaining permissions that weren't included.
|
Any reason this isn't being merged yet? Is it incorrect? Just curious. |
|
I too need coarse location permission for Android. |
|
Is this proposing to add in a separate type of readStorage for |
|
Not sure about this module, but in android in general, they are definitely separate permissions. They are not interchangeable though write includes read of course. Even upcoming Android 10 / Q maintains them, and they are separate, although they are now scoped per app https://developer.android.com/preview/privacy/scoped-storage |
|
I am closing this since this issue does not exists anymore with the 2.0.0 release. |
@yonahforst, merging this PR would allow for use of all dangerous Android permissions.
Thank you!