Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap targets are not sized appropriately in the footer #227

Closed
moshie opened this issue Feb 17, 2020 · 2 comments
Closed

Tap targets are not sized appropriately in the footer #227

moshie opened this issue Feb 17, 2020 · 2 comments

Comments

@moshie
Copy link
Contributor

moshie commented Feb 17, 2020 •
edited
Loading

When running a lighthouse check on the Footer component it fails the SEO metric for: "Tap targets are not sized appropriately".

More specifically the Blog and Careers links.

https://web.dev/tap-targets/?utm_source=lighthouse&utm_medium=devtools

Targets that are smaller than 48 px by 48 px or closer than 8 px apart fail the audit

The Blog link is too small and the Careers link is too close

I propose we increase the margin between items to 8px and make the links display block at mobile?

Screenshot 2020-02-17 at 12 10 23
@ubbe-xyz
Copy link
Contributor

Seems good to me 👌🏻

@moshie moshie mentioned this issue Feb 17, 2020
Merged
poteirard pushed a commit that referenced this issue Feb 18, 2020
@semantic-release-bot
chore(release): 2.11.2 [skip ci]
2c38af6 
## [2.11.2](v2.11.1...v2.11.2) (2020-02-18)

### Bug Fixes

* **footer:** update Footer links clickable area ([adfd2c1](adfd2c1)), closes [#227](#227)
* **footer:** update testing snapshots ([113f932](113f932)), closes [#227](#227)
@ubbe-xyz
Copy link
Contributor

Addressed on the above PR 🤙🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moshie @ubbe-xyz