Support PURE_PYTHON instead of AC_PURE_PYTHON

.github/workflows/tests.yml

@@ -92,6 +92,7 @@ jobs:
     # with `test`, and `docs` must use a subset.
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         python-version:
           - 2.7
@@ -171,6 +172,7 @@ jobs:
     needs: build-package
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         python-version:
           - 2.7
@@ -231,7 +233,7 @@ jobs:
           python -m coverage run -p -m zope.testrunner --test-path=src --auto-color --auto-progress
       - name: Run tests without C extensions
         run: |
-          AC_PURE_PYTHON=1 python -m coverage run -p -m zope.testrunner --test-path=src --auto-color --auto-progress
+          PURE_PYTHON=1 AC_PURE_PYTHON=1 python -m coverage run -p -m zope.testrunner --test-path=src --auto-color --auto-progress
       - name: Report Coverage
         run: |
           coverage combine

buildout.cfg

@@ -8,6 +8,7 @@ parts = interpreter test coverage
 [versions]
 AccessControl =
 RestrictedPython =
+Acquisition = 4.10
 
 [interpreter]
 recipe = zc.recipe.egg

src/AccessControl/ImplPython.py

@@ -26,13 +26,8 @@
 from ExtensionClass import Base
 from zope.interface import implementer
 
-# This is used when a permission maps explicitly to no permission.  We
-# try and get this from cAccessControl first to make sure that if both
-# security implementations exist, we can switch between them later.
-try:
-    from AccessControl.cAccessControl import _what_not_even_god_should_do
-except ImportError:
-    _what_not_even_god_should_do = []
+# We define our own `_what_not_even_god_should_do` to allow using PURE_PYTHON=1
+_what_not_even_god_should_do = []
 
 from AccessControl.interfaces import ISecurityManager
 from AccessControl.interfaces import ISecurityPolicy

src/AccessControl/Implementation.py

@@ -25,8 +25,10 @@
 
 """
 from __future__ import absolute_import
+
 import os
 
+
 # We cannot use `PURE_PYTHON` as this would be propagated to `ExtensionClass`
 # and `Acquisition`. Due to restrictions of python implementation concerning
 # proxies it is not possible to run all with pure python and we influence only

src/AccessControl/tests/testSecurityManager.py

@@ -14,6 +14,7 @@
 """Tests for the SecurityManager implementations
 """
 
+import os
 import unittest
 
 
@@ -250,6 +251,7 @@ def _getTargetClass(self):
         return SecurityManager
 
 
+@unittest.skipIf(os.environ.get('PURE_PYTHON'), reason="Test expects C impl.")
 class C_SecurityManagerTests(SecurityManagerTestBase,
                              ISecurityManagerConformance,
                              unittest.TestCase):

src/AccessControl/tests/testZopeGuards.py

@@ -167,9 +167,11 @@ class TestGuardedHasattr(GuardTestCase):
     def setUp(self):
         self.__sm = SecurityManager()
         self.__old = self.setSecurityManager(self.__sm)
+        gc.disable()
 
     def tearDown(self):
         self.setSecurityManager(self.__old)
+        gc.enable()
 
     def test_miss(self):
         from AccessControl.ZopeGuards import guarded_hasattr

src/AccessControl/tests/testZopeSecurityPolicy.py

@@ -11,6 +11,7 @@
 #
 ##############################################################################
 
+import os
 import sys
 import unittest
 from doctest import DocTestSuite
@@ -775,9 +776,10 @@ def loop():
 def test_suite():
     suite = unittest.TestSuite()
     suite.addTest(unittest.makeSuite(Python_ZSPTests))
-    suite.addTest(unittest.makeSuite(C_ZSPTests))
     suite.addTest(unittest.makeSuite(Python_SMTests))
-    suite.addTest(unittest.makeSuite(C_SMTests))
+    if not os.environ.get('PURE_PYTHON'):
+        suite.addTest(unittest.makeSuite(C_ZSPTests))
+        suite.addTest(unittest.makeSuite(C_SMTests))
     suite.addTest(DocTestSuite())
     suite.addTest(unittest.makeSuite(GetRolesWithMultiThreadTest))
     return suite

tox.ini

@@ -19,6 +19,9 @@ deps =
     setuptools < 52
     zc.buildout
 skip_install = true
+setenv =
+    PURE_PYTHON=1
+    AC_PURE_PYTHON=1
 
 [testenv:coverage]
 basepython = python3