Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary support for Python 3.12a7. #139

Closed
wants to merge 2 commits into from

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 17, 2023

@icemac icemac requested a review from dataflake April 17, 2023 06:04
@icemac icemac self-assigned this Apr 17, 2023
@icemac
Copy link
Member Author

icemac commented Apr 17, 2023

o no, Directory not empty is back on macOS.

Even the last successful build https://github.com/zopefoundation/AccessControl/actions/runs/4650409246/jobs/8229390839
had this problem.

@icemac
Copy link
Member Author

icemac commented Apr 17, 2023

Maybe a pre-release of zope.proxy would help.

@icemac
Copy link
Member Author

icemac commented Apr 17, 2023

zope.proxy has the same problem as depends on zope.security: https://github.com/zopefoundation/zope.proxy/actions/runs/4524463715/jobs/7968314536
But zope.security is fine: https://github.com/zopefoundation/zope.security/actions/runs/4713161605/jobs/8358679615
So a pre-release of zope.security might help.

@dataflake
Copy link
Member

dataflake commented Apr 17, 2023

You will see the failure as long as there are no x86_64 wheels found for the problematic dependencies. As soon as the GHA runner tries to build those wheels it will fail.

IMHO the fix is to change how those problematic packages are built in the first place. Those that try to install other C-based dependencies and then find header files all break. Those that have their own copy of the dependency header files don't break. zope.security tries that dance with zope.proxy.

@icemac
Copy link
Member Author

icemac commented Apr 17, 2023

Updating zope.security to a7, breaks the tests over there: zopefoundation/zope.security#97

Now we have a problem, Houston.

@dataflake
Copy link
Member

That's unrelated to the issue here, though. zope.security and/or zope.proxy apparently need some massaging to be Python 3.12-compatible.

@icemac
Copy link
Member Author

icemac commented Apr 18, 2023

@dataflake wrote:

Those that try to install other C-based dependencies and then find header files all break.

So you'd suggest to copy over the needed header files to the depending packages and drop using setup_requires. – Let my try this here.

@icemac
Copy link
Member Author

icemac commented Apr 18, 2023

No, AccessControl is not part of the problem, it has copies of the needed header files (which should be updated BTW (#140)), so I'll have a look at zope.proxy.

@dataflake
Copy link
Member

AccessControl is not the problem and I didn't say it was. zope.security has the problem. It tries to install zope.proxy to get at the headers.

@icemac
Copy link
Member Author

icemac commented Apr 19, 2023

Superseded by #141.

@icemac icemac closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants