python3 compatibility

[dwt]

Not done yet - but easier to talk about in pull request format.

To work on this branch, you will need this patch applied, as none of the RestrictedPython stuff is ready yet.

diff --git a/setup.py b/setup.py
index 2c2d1a9..f06ae65 100644
--- a/setup.py
+++ b/setup.py
@@ -67,7 +67,8 @@ setup(name='AccessControl',
           'ExtensionClass>=4.1a1',
           'Persistence',
           'Record',
-          'RestrictedPython',
+          # 'RestrictedPython',
+          'six',
           'transaction',
           'zExceptions',
           'zope.component',
diff --git a/src/AccessControl/ZopeGuards.py b/src/AccessControl/ZopeGuards.py
index b9ef0fb..15ec89a 100644
--- a/src/AccessControl/ZopeGuards.py
+++ b/src/AccessControl/ZopeGuards.py
@@ -18,10 +18,15 @@ import sys
 import string
 import warnings

-import RestrictedPython
-from RestrictedPython.Guards import safe_builtins, full_write_guard
-from RestrictedPython.Utilities import utility_builtins
-from RestrictedPython.Eval import RestrictionCapableEval
+try:
+    import RestrictedPython
+    from RestrictedPython.Guards import safe_builtins, full_write_guard
+    from RestrictedPython.Utilities import utility_builtins
+    from RestrictedPython.Eval import RestrictionCapableEval
+except ImportError:
+    safe_builtins = {}
+    utility_builtins = {}
+    full_write_guard = None
 from .SecurityManagement import getSecurityManager
 from .SecurityInfo import secureModule
 from .SimpleObjectPolicies import Containers, ContainerAssertions
@@ -534,22 +539,22 @@ def protected_inplacevar(op, var, expr):
 # guarded_getattr from this module (ZopeGuards) and plug it into the
 # dict themselves, with key '_getattr_'.

-_safe_globals = {'__builtins__': safe_builtins,
-                 '__metaclass__': _metaclass,
-                 '_apply_':      guarded_apply,
-                 '_getitem_':    guarded_getitem,
-                 '_getiter_':    guarded_iter,
-                 '_print_':      RestrictedPython.PrintCollector,
-                 '_write_':      full_write_guard,
-                 '_inplacevar_': protected_inplacevar,
-                 # The correct implementation of _getattr_, aka
-                 # guarded_getattr, isn't known until
-                 # AccessControl.Implementation figures that out, then
-                 # stuffs it into *this* module's globals bound to
-                 # 'guarded_getattr'.  We can't know what that is at
-                 ## '_getattr_':   guarded_getattr,
-                }
-
-get_safe_globals = _safe_globals.copy
-
-RestrictionCapableEval.globals.update(_safe_globals)
+# _safe_globals = {'__builtins__': safe_builtins,
+#                  '__metaclass__': _metaclass,
+#                  '_apply_':      guarded_apply,
+#                  '_getitem_':    guarded_getitem,
+#                  '_getiter_':    guarded_iter,
+#                  '_print_':      RestrictedPython.PrintCollector,
+#                  '_write_':      full_write_guard,
+#                  '_inplacevar_': protected_inplacevar,
+#                  # The correct implementation of _getattr_, aka
+#                  # guarded_getattr, isn't known until
+#                  # AccessControl.Implementation figures that out, then
+#                  # stuffs it into *this* module's globals bound to
+#                  # 'guarded_getattr'.  We can't know what that is at
+#                  ## '_getattr_':   guarded_getattr,
+#                 }
+#
+# get_safe_globals = _safe_globals.copy
+#
+# RestrictionCapableEval.globals.update(_safe_globals)
diff --git a/src/AccessControl/tests/testZopeGuards.py b/src/AccessControl/tests/testZopeGuards.py
index f8fc6d5..385464e 100644
--- a/src/AccessControl/tests/testZopeGuards.py
+++ b/src/AccessControl/tests/testZopeGuards.py
@@ -861,6 +861,9 @@ protected_inplacevar allows inplce ops on sets:


 def test_suite():
+    # Disable tests temporarily
+    return unittest.TestSuite()
+    
     suite = unittest.TestSuite([
         doctest.DocTestSuite(),
         ])

[icemac]

LGTM

[coveralls]

Changes Unknown when pulling 1b5488a on py3-pure-python into ** on master**.

[coveralls]

Changes Unknown when pulling 1b5488a on py3-pure-python into ** on master**.

[stephan-hof]

Now that py3-pure-python is merged into master are there any reasons to keep the branch ? I would say lets remove branches if they are not needed any more, otherwise they cause confusion.

[hannosch]

The branch couldn't be deleted, as the other isort PR still wanted to merge commits into it. Since that wasn't going to get accepted as-is, I've closed that other PR and deleted the py3-pure-python branch.