re #60: remove duplicate guard against * imports #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to the ticket rationale, this doesn't even rely on a guard in a current enough version of RestrictedPython as even SecurityManager.validate will raise Unauthorized if '*' is in the from-list.
icemac
reviewed
Oct 2, 2018
| @@ -67,6 +67,9 @@ def testPublicModule(self): | |||
| self.assertAuth('AccessControl.tests.public_module.submodule', | |||
| ('pub',)) | |||
|
|
|||
| def test_star_import_not_allowed(self): | |||
| self.assertUnauth('AccessControl.tests.public_module', ('*',)) | |||
|
|
|||
There was a problem hiding this comment.
What is the difference to the next test (test_public_module_asterisk_not_allowed)?
There was a problem hiding this comment.
That was a left-over from some experimentation, I've backed it out now.
|
@icemac: We don't need a more recent minimum version of RestrictedPython since the guard against * imports doesn't even rely on it. This is actually the point of the test that I had doubled in the first commit to this PR; these tests refer to the AccessControl guard only, which is already enough to block * imports (by virtue of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the ticket rationale, this doesn't even rely on a guard in a
current enough version of RestrictedPython as even SecurityManager.validate
will raise Unauthorized if '*' is in the from-list.
fixes #60