Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings #68

Merged
merged 7 commits into from Oct 5, 2018
Merged

Fix deprecation warnings #68

merged 7 commits into from Oct 5, 2018

Conversation

tschorr
Copy link
Contributor

@tschorr tschorr commented Oct 5, 2018

@tschorr tschorr changed the title Fix deprecation warnings WIP: Fix deprecation warnings Oct 5, 2018
@tschorr tschorr changed the title WIP: Fix deprecation warnings Fix deprecation warnings Oct 5, 2018
@tschorr tschorr requested a review from icemac October 5, 2018 13:52
@tschorr tschorr self-assigned this Oct 5, 2018
icemac
icemac approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac merged commit 52034b8 into master Oct 5, 2018
@icemac icemac deleted the fix_deprecation_warnings branch October 5, 2018 15:11
@pbauer
Copy link
Member

pbauer commented Oct 5, 2018 •
edited

@tschorr I am not 100% really sure but I think this change breaks the beahavior of @postonly.
E.g. plone.api.group.create() fails because the kwargs are dropped in Products.PlonePAS.tools.groups.GroupsTool.addGroup that is decorated.

For many failing tests see https://jenkins.plone.org/view/PLIPs/job/plip-py3/882/consoleText

@pbauer pbauer mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees

@tschorr tschorr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tschorr @pbauer @icemac