Merge pull request #22 from zopefoundation/issue21

call PyObject_GC_UnTrack() in tp_dealloc()
zopefoundation · Sep 11, 2017 · a4a7cee · a4a7cee
2 parents e509c01 + 11c621e
commit a4a7cee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
 4.5.0 (unreleased)
 ------------------
 
+- Fix the extremely rare potential for a crash when the C extensions
+  are in use. See `issue 21 <https://github.com/zopefoundation/Acquisition/issues/21>`_.
+
 
 4.4.2 (2017-05-12)
 ------------------

diff --git a/src/Acquisition/_Acquisition.c b/src/Acquisition/_Acquisition.c
@@ -415,6 +415,7 @@ Wrapper_clear(Wrapper *self)
 static void
 Wrapper_dealloc(Wrapper *self)
 {
+    PyObject_GC_UnTrack(OBJECT(self));
     Wrapper_clear(self);
     Py_TYPE(self)->tp_free(OBJECT(self));
 }