Make object.__getattribute__ work in methods wrapped with an acquisition wrapper. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his. Also provides a more informative traceback if lookup failed in that case which assists debugging if the inheritance hierarchy is complex.
…on wrapper. Fixes #9. Dict-based objects are easy, just an assignment. But objects with __slots__ require generating new classes on-the-fly with matching descriptors (which is how slots are actually implemented). One prominent use-case is the `persistent` library which is slot-based. This is only implemented for the pure-python version because it's only been observed to be a problem in that use-case.
…. Delete the traceback local when we're done with it. Properly specify the slots in the tests.
|
It's very odd how the line notes are showing up on this one, different than they did on zopefoundation/persistent#20. But I've addressed everything so far, great feedback, I can't believe I left _DERIVED unmangled. |
tseaver
added a commit
that referenced
this pull request
May 19, 2015
…ypes Make object.__getattribute__ work in methods wrapped with an acquisition wrapper.
|
@jamadden Thanks for your hard work! |
|
@tseaver My pleasure! I continue to be amazed at how flexible Python is. Thanks for getting this released. |
|
Released via https://pypi.python.org/pypi/Acquisition/4.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9.
Builds on the commits for the previous issue, #7 slash #8 because both of them are required to do any serious Persistent work in pure-Python when Acquisition is involved and this is now the branch we're continuing to test our application against.