Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.6 and 3.2, claim support for Python 3.5. #11

Merged
merged 2 commits into from
Sep 30, 2016

Conversation

icemac
Copy link
Member

@icemac icemac commented Sep 29, 2016

No description provided.

- TBD
- Drop support for Python 2.6 and 3.2.

- Claim support for Python 3.5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer "Add support" to "Claim support": there isn't support until we test for it.


[report]
precision = 2
omit = */tests.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add show_missing = True to the [report] section, too? We are missing two lines at present.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why omit reporting on the tests? Those should be at 100% too.

@@ -0,0 +1,7 @@
[run]
branch = True
source = AccessControl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this line can't be correct: this is Acquisition, not AccessControl.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I copied the file from there and this line seem to have slipped through my fingers. But it seems that AccessControl here does not harm.
Changed it anyway.

@icemac
Copy link
Member Author

icemac commented Sep 30, 2016

@tseaver Thank you for your feedback, I changed the code accordingly.

@hannosch hannosch merged commit 66cde66 into master Sep 30, 2016
@hannosch hannosch deleted the update-supported-versions branch September 30, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants