-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 2.6 and 3.2, claim support for Python 3.5. #11
Conversation
- TBD | ||
- Drop support for Python 2.6 and 3.2. | ||
|
||
- Claim support for Python 3.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer "Add support" to "Claim support": there isn't support until we test for it.
|
||
[report] | ||
precision = 2 | ||
omit = */tests.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add show_missing = True
to the [report]
section, too? We are missing two lines at present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why omit reporting on the tests? Those should be at 100% too.
@@ -0,0 +1,7 @@ | |||
[run] | |||
branch = True | |||
source = AccessControl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this line can't be correct: this is Acquisition
, not AccessControl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I copied the file from there and this line seem to have slipped through my fingers. But it seems that AccessControl
here does not harm.
Changed it anyway.
@tseaver Thank you for your feedback, I changed the code accordingly. |
No description provided.