Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7 and 3.5. #6

Closed
wants to merge 11 commits into from
Closed

Conversation

icemac
Copy link
Member

@icemac icemac commented Sep 28, 2020

No description provided.

@icemac icemac self-assigned this Sep 28, 2020
@dataflake
Copy link
Member

.travis.yml and setup.py still refer to Python 2

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming we're fine with dropping 2.7 as a group

(I wanted to link to a previous discussion about that but couldn't find it)

.travis.yml Show resolved Hide resolved
src/AuthEncoding/AuthEncoding.py Outdated Show resolved Hide resolved
src/AuthEncoding/AuthEncoding.py Outdated Show resolved Hide resolved
src/AuthEncoding/AuthEncoding.py Show resolved Hide resolved
@dataflake
Copy link
Member

lgtm, assuming we're fine with dropping 2.7 as a group

Michael worked on several packages yesterday and wanted to just drop 3.5 first, because Zope 5 doesn't support it. But he overlooked that dropping 3.5 would make a package potentially incompatible with Zope 4.x, which explicitly supports it. Then we both reasoned that he could just make the full step of dropping 2.7 as well, so the package would end up for Zope 5 only. But Jason Madden spoke up about some packages where he definitely wants to retain 2.7.

I'm now thinking that we should stop such efforts to drop compatibility unless there are really good reasons and revisit it when Zope 5 has been around a bit and adopted by the bigger "customers" in the ecosystem, e.g. Plone.

@dataflake dataflake changed the title Add support for Python 3.8 and 3.9. Drop support for Python 3.5. Drop support for Python 2.7 and 3.5. Sep 30, 2020
@dataflake
Copy link
Member

To get this out of the critical path for a Zope 5 release I have pulled out the changes that add support for Python 3.8 and Python 3.9 and merged those into master. I then published release 4.2, which we can use for Zope 5 (and 4).

This PR only contains the changes for dropping Python 2 and Python 3.5 support, and that should wait until we have consensus on when to drop this support for packages where keeping that support doesn't introduce a big burden. I added the do not merge tag for that reason.

Michael Howitz and others added 2 commits October 13, 2020 08:35
Co-authored-by: Marius Gedminas <marius@gedmin.as>
@dataflake
Copy link
Member

Superceded by #14

@dataflake dataflake closed this Jan 11, 2023
@dataflake dataflake deleted the update-python-versions branch January 11, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants