Fit the 'repr' of bucket objects.

Broeken version could contain garbage characters.

BTrees/BucketTemplate.c

@@ -1840,9 +1840,9 @@ bucket_repr(Bucket *self)
     {
         Py_DECREF(r);
 #ifdef PY3K
-        return PyUnicode_DecodeLatin1(repr, sizeof(repr), "surrogateescape");
+        return PyUnicode_DecodeLatin1(repr, strlen(repr), "surrogateescape");
 #else
-        return PyBytes_FromStringAndSize(repr, sizeof(repr));
+        return PyBytes_FromStringAndSize(repr, strlen(repr));
 #endif
     }
     else

BTrees/tests/common.py

@@ -202,6 +202,18 @@ def _populate(self, t, l):
         for i in range(l):
             t[i]=i
 
+    def testShortRepr(self):
+        # test the repr because buckets have a complex repr implementation
+        # internally the cutoff from a stack allocated buffer to a heap
+        # allocated buffer is 10000.
+        t = self._makeOne()
+        for i in range(5):
+            t[i] = i
+        r = repr(t)
+        # Make sure the repr is **not* 10000 bytes long for a shrort bucket.
+        # (the buffer must be terminated when copied).
+        self.assertTrue(len(r) < 10000)
+
     def testRepr(self):
         # test the repr because buckets have a complex repr implementation
         # internally the cutoff from a stack allocated buffer to a heap

CHANGES.rst

@@ -5,7 +5,8 @@
 4.0.5 (unreleased)
 ------------------
 
-- TBD
+- Fit the ``repr`` of bucket objects, which could contain garbage
+  characters.
 
 
 4.0.4 (2013-01-12)